libosmocore[master]: logging: use enum to set timestamp format

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 19 14:19:25 UTC 2018


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/5857/4/include/osmocom/core/logging.h
File include/osmocom/core/logging.h:

Line 255: 	unsigned int print_timestamp:1;
the question here is whether we can avoid those deprecated /new members and simply change the existing one.  Chances are probably extremely low that anyone has implemented a log target outside of libosmocore itself, so an application would not have had any direct reference to the struct or its layout - only referring to pointers as those are returned if log targets are created. Might be worth investigating if this is true for the osmocom codebase and then simply change in-place?


-- 
To view, visit https://gerrit.osmocom.org/5857
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70ecee543c266df54191d3e86401466cd1a5c0a6
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list