osmo-bsc[master]: vty: add various manual handover and assignment trigger comm...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 19 14:15:04 UTC 2018


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/5889/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:

Line 1420:       "handover <0-255> <0-255> <0-7> LCHAN_NR <0-255>",
lchan numbers are 0..8 as the lchan[] array is 8 in size. Rationale: SDCCH/8 is the channel with most logical channels in a timeslot.  so it should be <0-7> instead of LCHAN_NR, IMHO


Line 1430:       "assignment <0-255> <0-255> <0-7> LCHAN_NR",
same here of course


Line 1529:       "Pick any actively used lchan and handover to any other BTS."
might be worth that it only will select any *voice* lchan, not "any actively used lchan" such as SDCCN.


Line 1550:       "Pick any actively used lchan and re-assign within the same BTS.\n")
same here again.


-- 
To view, visit https://gerrit.osmocom.org/5889
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9745609f2620baa09a693b713d76e355e798abc7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list