osmo-bts[master]: Allow specifying sysmocom headers explicitly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Jan 19 13:37:59 UTC 2018


Patch Set 2: Code-Review-1

I agree with Max that the --with-sysmobts= arg matches the --with-litecell15= and --with-octsdr options. We won't add '-headers' to the others because that would only create build fallout. And we should keep the pattern similar, so let's keep it as --with-sysmobts for hysterical raisins.

Still important to me is: using --with-sysmobts makes sense only when it implies --enable-sysmocom-bts (If I pass --with-sysmobts alone and it has no effect, I would consider it a bug).

And --enable-sysmocom-bts only makes sense when it uses a sane default for --with-sysmobts (what stsp said). If the empty value works, then that would be fine. Maybe an explicit './' would be ... more explicit.

-- 
To view, visit https://gerrit.osmocom.org/5870
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0416a9f4c428189cd9c3909c8bd016ca2908128a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list