[PATCH] osmo-bsc[master]: Allow assignment to TCH channel with signalling only mode

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Jan 19 03:04:01 UTC 2018


Review at  https://gerrit.osmocom.org/5909

Allow assignment to TCH channel with signalling only mode

This makes sense, if silent call is used. Assignment allows to change from
SDCCH (or whatever was available) to given TCH rate.

Change-Id: I2efe9d7ab429e902581ebb9e0e006f2aec6d8972
---
M src/libbsc/bsc_api.c
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/5909/1

diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c
index 53d0281..545cf36 100644
--- a/src/libbsc/bsc_api.c
+++ b/src/libbsc/bsc_api.c
@@ -236,7 +236,8 @@
 
 	/* copy new data to it */
 	new_lchan->tch_mode = chan_mode;
-	new_lchan->rsl_cmode = RSL_CMOD_SPD_SPEECH;
+	new_lchan->rsl_cmode = (chan_mode == GSM48_CMODE_SIGN) ?
+					RSL_CMOD_SPD_SIGN : RSL_CMOD_SPD_SPEECH;
 
 	/* handle AMR correctly */
 	if (chan_mode == GSM48_CMODE_SPEECH_AMR)
@@ -354,8 +355,6 @@
 {
 	switch (chan_mode) {
 	case GSM48_CMODE_SIGN:
-		/* signalling is always possible */
-		return 1;
 	case GSM48_CMODE_SPEECH_V1:
 	case GSM48_CMODE_SPEECH_AMR:
 	case GSM48_CMODE_DATA_3k6:

-- 
To view, visit https://gerrit.osmocom.org/5909
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2efe9d7ab429e902581ebb9e0e006f2aec6d8972
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list