This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 2: -Code-Review > This is the main change of this patch. Adding yes, string splitting - no. But like I've said, I don't consider it to be blocker. > following the pattern present in this file So this slipped passed review sometime before. Should be fixed as well. > could you clarify? It's documented in https://www.gnu.org/software/automake/manual/html_node/Linking.html In a nutshell, LDADD applies to all the programs, prog_LDADD applies single program. So having only "prog_LDADD = $(LDADD)" is confusing and redundant. > to fix LDADD in a separate patch? Sure but please fix all such entries and submit it together with this one. -- To view, visit https://gerrit.osmocom.org/5844 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id084e6e6efd25cd62b1bd7a4fc7c5985c39130c6 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: No