libosmocore[master]: tests: fix LDADD: link libosmovty from current build

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 17 12:49:12 UTC 2018


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/5844/1/tests/Makefile.am
File tests/Makefile.am:

Line 5: 	$(top_builddir)/src/vty/libosmovty.la \
Seems like unrelated cosmetic change, but we shouldn't consider it merge blocker.


Line 151: vty_vty_test_LDADD = $(LDADD)
That's unnecessary: LDADD is used by default so you can just remove the line entirely.


-- 
To view, visit https://gerrit.osmocom.org/5844
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id084e6e6efd25cd62b1bd7a4fc7c5985c39130c6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list