[PATCH] osmo-ci[master]: Fix missing OsmoPCU gerrit verification

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Jan 12 15:18:17 UTC 2018


Review at  https://gerrit.osmocom.org/5770

Fix missing OsmoPCU gerrit verification

The [yes, no] tuple was automatically converted to [True, False] by the
jenkins-job-builder but the combination filter still used old literal
check. Fix this by using boolean from the very beginning.

Change-Id: Idac6e53b1e0addbcb5b6c99b8051e1e0ad26bc5b
---
M jobs/gerrit-verifications.yml
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/70/5770/1

diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index b421e34..192d0ad 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -149,15 +149,15 @@
           a1_name: FIRMWARE_VERSION
           a1: !!python/tuple [master, v2017.01, origin/nrw/litecell15-next]
           a2_name: with_vty
-          a2: !!python/tuple [yes ,no]
+          a2: !!python/tuple [True, False]
           a3_name: with_dsp
           a3: !!python/tuple [sysmo, lc15, none]
           combination_filter: >
-            (with_vty == "yes" && with_dsp == "sysmo" && FIRMWARE_VERSION=="master") ||
-            (with_vty == "yes" && with_dsp == "lc15" && FIRMWARE_VERSION=="master") ||
-            (with_vty == "yes" && with_dsp == "lc15" && FIRMWARE_VERSION=="v2017.01") ||
-            (with_vty == "yes" && with_dsp == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15-next") ||
-            (with_vty == "no" && with_dsp == "none" && FIRMWARE_VERSION=="master")
+            (with_vty == "True" && with_dsp == "sysmo" && FIRMWARE_VERSION=="master") ||
+            (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="master") ||
+            (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="v2017.01") ||
+            (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15-next") ||
+            (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master")
 
       - osmo-python-tests:
           repos_url: 'ssh://jenkins@gerrit.osmocom.org:29418/python/{repos}'

-- 
To view, visit https://gerrit.osmocom.org/5770
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idac6e53b1e0addbcb5b6c99b8051e1e0ad26bc5b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list