osmo-bsc[master]: Show the BTS number for outgoing paging commands in debug log.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 12 14:28:00 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5685/1/src/libbsc/paging.c
File src/libbsc/paging.c:

Line 89: 	LOGP(DPAG, LOGL_INFO, "Going to send paging commands: bts: %d imsi: %s tmsi: "
it's typically best practise to use something like "(bts=%d) " at the beginning of the line, similar like what we do in lchan_name and in other parts of the code.  So the identification/context comes first, then the log message.


-- 
To view, visit https://gerrit.osmocom.org/5685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b6e03087fc2dfecb6235c5ed1494d3c9b4bbf0e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list