This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/5752/3/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: Line 367: (unrelated whitespace change) Line 392: if (page_subscriber(msc, bts, tmsi, lac, mi_string, chan_needed) < 0) > why are we aborting the loop if the paging failed? I mean, if there are 10 I see that the only failure page_subscriber() returns is currently a failure to allocate a subscriber. But I also think it is better to not cancel the loop, page_subsrciber() might change and then we have created an obscure bug. (Same for the other bts iterations). -- To view, visit https://gerrit.osmocom.org/5752 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c72c7f83e53988eb9fedf314b1dc459836833d Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes