osmo-msc[master]: Permit a set of multiple different A5 ciphers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 11 11:46:20 UTC 2018


Patch Set 2: Code-Review+1

(2 comments)

+2 if the default a5_encryption should really change

https://gerrit.osmocom.org/#/c/5559/2/src/libcommon-cs/common_cs.c
File src/libcommon-cs/common_cs.c:

Line 60: 	net->a5_encryption_mask = (1 << 3) | (1 << 1);
before, the default was to do no encryption (a5_encryption == 0), do you intend to change that? Otherwise | (1 << 0) I guess


https://gerrit.osmocom.org/#/c/5559/2/src/libcommon-cs/common_cs_vty.c
File src/libcommon-cs/common_cs_vty.c:

Line 160: 	"GSM A5 Air Interface Encryption\n"
(might be nice to keep the doc of '0: no encryption' ... not sure how helpful the others really are)


-- 
To view, visit https://gerrit.osmocom.org/5559
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79a4e2892eb5fbecc3d84e11dceffb7149db264b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list