osmo-trx[master]: tests: Timeval: adapt to have reproducible output and enable...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Jan 10 10:35:37 UTC 2018


Patch Set 1:

> This is odd - if test output is always empty, how can we be sure
 > that the test was executed at all? I think it's better to log at
 > least what kind of test is executing. Even better would be to log
 > smth in case of error instead of using assert: if we hit assert
 > than we don't know what happens with the test code beyond assert
 > point. If we log error and continue, we might see several errors at
 > once and the test would still fail due to output difference.
 > Although it might be matter of personal preference.

AT_CHECK checks the return code of the program, so we catch if it fails or not.
I'll add a small print to the stdout to check against it, though, as it gives more confidence when checking if the test is run.
If the test fails with assert, then you can easily run it with gdb and get a backtrace and see what's going on, so no issue with it. Some tests also print extra information to stderr which is logged into testsuite.log if the test fails.

-- 
To view, visit https://gerrit.osmocom.org/5708
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a79892ba3c934879a171789e0edb357277acae4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list