osmo-pcu[master]: TBF: cleanup state flag handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Jan 8 17:53:30 UTC 2018


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/5367/4/src/bts.cpp
File src/bts.cpp:

Line 1039: 			new_tbf->state_flags &= ~(1 << GPRS_RLCMAC_FLAG_CCCH);
We could remove this line as well, couldn't we? The flag is already cleared by check_n_clear if we enter this if-block.


-- 
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list