[PATCH] gapk[master]: Fix BENCHMARK_STOP call for both AMR and FR codecs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Jan 8 17:48:41 UTC 2018


Review at  https://gerrit.osmocom.org/5688

Fix BENCHMARK_STOP call for both AMR and FR codecs

The BENCHMARK_STOP should be called with a correct codec type and
a correct operation type (encode or decode). Otherwise the results
could be incorrect.

Change-Id: Ie90e85ca8d9ec3175a58dde60525e0b7d6daf608
---
M src/codec_amr.c
M src/codec_fr.c
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/88/5688/1

diff --git a/src/codec_amr.c b/src/codec_amr.c
index 4aae733..ca614ed 100644
--- a/src/codec_amr.c
+++ b/src/codec_amr.c
@@ -78,7 +78,7 @@
 		(unsigned char*) cod,
 		1
 	);
-	BENCHMARK_STOP(CODEC_EFR, 1);
+	BENCHMARK_STOP(CODEC_AMR, 1);
 
 	return rv;
 }
@@ -95,7 +95,7 @@
 		(short *) pcm,
 		0
 	);
-	BENCHMARK_STOP(CODEC_EFR, 0);
+	BENCHMARK_STOP(CODEC_AMR, 0);
 
 	return PCM_CANON_LEN;
 }
diff --git a/src/codec_fr.c b/src/codec_fr.c
index 2ce44b4..917f34b 100644
--- a/src/codec_fr.c
+++ b/src/codec_fr.c
@@ -74,7 +74,7 @@
 	memcpy(cod_b, cod, FR_CANON_LEN);
 	BENCHMARK_START;
 	rc = gsm_decode(gh, (gsm_byte*)cod_b, (gsm_signal*)pcm);
-	BENCHMARK_STOP(CODEC_FR, 1);
+	BENCHMARK_STOP(CODEC_FR, 0);
 	if (rc < 0)
 		return rc;
 	return PCM_CANON_LEN;

-- 
To view, visit https://gerrit.osmocom.org/5688
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie90e85ca8d9ec3175a58dde60525e0b7d6daf608
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list