osmo-sgsn[master]: gprs_llc: tx dl ud: make mismatching LLE not crash osmo-sgsn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jan 8 10:43:01 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5662/1/src/gprs/gprs_llc.c
File src/gprs/gprs_llc.c:

Line 375: 		if (!(msgb_tlli(msg) == mmctx->gb.llme->tlli
> Global negation is harder to read and I don't think we use this style anywh
to show that the patch does not modify the condition.


-- 
To view, visit https://gerrit.osmocom.org/5662
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07a40960920dbc594192530c3a145f9a5d2a9c81
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list