osmo-bsc[master]: Support control connection status query for a particular MSC.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Jan 5 20:20:19 UTC 2018


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/5630/2/src/osmo-bsc/osmo_bsc_ctrl.c
File src/osmo-bsc/osmo_bsc_ctrl.c:

Line 75: }
> It's better to use CTRL_CMD_DEFINE_RO to avoid boilerplate.
Yes, indeed. Thanks! I got confused and assumed that CTRL_CMD_DEFINE_RO() didn't expand to the function signature I needed, but now realized that it fits my case exactly.


Line 90: 	return CTRL_CMD_REPLY;
> If it's unused than why not remove it?
There is more unused code which uses this variable.
So just removing this line would break the build.

I plan to remove this line along with the other code later. I would rather not mix feature additions with lots of code removal in a single changeset


-- 
To view, visit https://gerrit.osmocom.org/5630
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd41474a1be80e782b19ec337c856b5efc593fa8
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list