[PATCH] libosmocore[master]: Remove unused timeval parameters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 3 16:27:02 UTC 2018


Review at  https://gerrit.osmocom.org/5631

Remove unused timeval parameters

Remove timeval parameters from NS and BSSGP structs which were replaced
by timespec which is required for monotonic clocks.

Change-Id: I16ffe9aca21be1fa71184abc57a5745923c5cfcb
---
M TODO-RELEASE
M include/osmocom/gprs/gprs_bssgp.h
M include/osmocom/gprs/gprs_ns.h
3 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/5631/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 8af8f48..2c9d85c 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -12,3 +12,5 @@
 core		osmo_time_elapsed()	add function to estimate elapsed time
 gb		struct gprs_nsvc	add t_start parameter
 gb		struct bssgp_flow_control	add t_last_pdu parameter
+gb		struct gprs_nsvc		remove timer_started parameter
+gb		struct bssgp_flow_control	remove time_last_pdu parameter
diff --git a/include/osmocom/gprs/gprs_bssgp.h b/include/osmocom/gprs/gprs_bssgp.h
index 7b3ccec..efd2bc3 100644
--- a/include/osmocom/gprs/gprs_bssgp.h
+++ b/include/osmocom/gprs/gprs_bssgp.h
@@ -66,7 +66,6 @@
 	uint32_t bucket_leak_rate; 	/*!< leak rate of the bucket (octets/sec) */
 
 	uint32_t bucket_counter;	/*!< number of tokens in the bucket */
-	struct timeval time_last_pdu;	/*!< deprecated! will be replaced by t_last_pdu eventually */
 	struct timespec t_last_pdu;	/*!< timestamp of last PDU sent */
 
 	/* the built-in queue */
diff --git a/include/osmocom/gprs/gprs_ns.h b/include/osmocom/gprs/gprs_ns.h
index a303732..987d5dd 100644
--- a/include/osmocom/gprs/gprs_ns.h
+++ b/include/osmocom/gprs/gprs_ns.h
@@ -127,7 +127,6 @@
 
 	struct osmo_timer_list timer;
 	enum nsvc_timer_mode timer_mode;
-	struct timeval timer_started; /* deprecated! will be replaced by t_start eventually */
 	struct timespec t_start;
 	int alive_retries;
 

-- 
To view, visit https://gerrit.osmocom.org/5631
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16ffe9aca21be1fa71184abc57a5745923c5cfcb
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list