[MERGED] osmo-bts[master]: pcu_sock: LOG + drop PCU DATA.req for inactive lchan

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 28 22:21:31 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: pcu_sock: LOG + drop PCU DATA.req for inactive lchan
......................................................................


pcu_sock: LOG + drop PCU DATA.req for inactive lchan

Change-Id: I11c622967885d594ef7e1c24b9bafd0fb8fd400c
---
M src/common/pcu_sock.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index cd8e0b2..e98769d 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -534,6 +534,12 @@
 			rc = -EINVAL;
 			break;
 		}
+		if (ts->lchan[0].state != LCHAN_S_ACTIVE) {
+			LOGP(DPCU, LOGL_ERROR, "%s: Received PCU DATA request for inactive lchan\n",
+				gsm_ts_name(ts));
+			rc = -EINVAL;
+			break;
+		}
 		is_ptcch = (data_req->sapi == PCU_IF_SAPI_PTCCH);
 		rc = l1sap_pdch_req(ts, is_ptcch, data_req->fn, data_req->arfcn,
 			data_req->block_nr, data_req->data, data_req->len);

-- 
To view, visit https://gerrit.osmocom.org/7008
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11c622967885d594ef7e1c24b9bafd0fb8fd400c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list