[PATCH] osmo-bts[master]: octphy: replace #warning with #pragma message

dexter gerrit-no-reply at lists.osmocom.org
Wed Feb 28 12:23:27 UTC 2018


Review at  https://gerrit.osmocom.org/6992

octphy: replace #warning with #pragma message

warning causes the compiler to throw an actual warning. Lets
change those intentional warnings to messages.

Change-Id: I2fc83a1a07db9c569b93f29835bf3a0fd8ef4ef5
---
M src/osmo-bts-octphy/l1_if.c
M src/osmo-bts-octphy/l1_oml.c
M src/osmo-bts-octphy/l1_tch.c
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/6992/1

diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c
index e94b642..700cc80 100644
--- a/src/osmo-bts-octphy/l1_if.c
+++ b/src/osmo-bts-octphy/l1_if.c
@@ -660,7 +660,7 @@
 		if (l1sap->u.info.type == PRIM_INFO_ACTIVATE)
 			l1if_rsl_chan_act(lchan);
 		else if (l1sap->u.info.type == PRIM_INFO_MODIFY) {
-#warning "Mode Modify is currently not not supported for Octasic PHY"
+#pragma message ("Mode Modify is currently not supported for Octasic PHY (OS#3015)")
 			/* l1if_rsl_mode_modify(lchan); */
 		} else if (l1sap->u.info.u.act_req.sacch_only)
 			l1if_rsl_deact_sacch(lchan);
diff --git a/src/osmo-bts-octphy/l1_oml.c b/src/osmo-bts-octphy/l1_oml.c
index d57228d..018a4f9 100644
--- a/src/osmo-bts-octphy/l1_oml.c
+++ b/src/osmo-bts-octphy/l1_oml.c
@@ -1722,7 +1722,7 @@
 
 int bts_model_change_power(struct gsm_bts_trx *trx, int p_trxout_mdBm)
 {
-#warning "Implement bts_model_change_power based on TRX_MODIFY_RF_CID"
+#pragma message ("Implement bts_model_change_power based on TRX_MODIFY_RF_CID (OS#3016)")
 	return 0;
 }
 
diff --git a/src/osmo-bts-octphy/l1_tch.c b/src/osmo-bts-octphy/l1_tch.c
index eee24aa..bb7a0e7 100644
--- a/src/osmo-bts-octphy/l1_tch.c
+++ b/src/osmo-bts-octphy/l1_tch.c
@@ -119,7 +119,7 @@
 				unsigned int payload_len)
 {
 #ifndef USE_L1_RTP_MODE
-#warning "We don't support EFR with L1 that doesn't support RTP mode!"
+#pragma message ("We don't support EFR with L1 that doesn't support RTP mode!")
 #else
 	memcpy(l1_payload, rtp_payload, payload_len);
 

-- 
To view, visit https://gerrit.osmocom.org/6992
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fc83a1a07db9c569b93f29835bf3a0fd8ef4ef5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>


More information about the gerrit-log mailing list