osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_bb.py: add FAKE_RSSI and FAKE_TOA commands

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 27 13:04:13 UTC 2018


Patch Set 2:

I'm completely fine with FAKE_TOA, but why would you ever intenionally use a float value?  The Burst data carries int16_t. IF you input a float value, you may end up having conversion/rounding differences in how python rounds the float to how the Test suite rounds the float - they may even run on different machines, etc. 

In the end, we want to generate an int16_t from fake_trx inside the bursts.  Why would you use a different type as the input parameter?

-- 
To view, visit https://gerrit.osmocom.org/6846
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia23becec4104d47e7b22350db67b8834d6f1ad1b
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: No


More information about the gerrit-log mailing list