[MERGED] osmo-bsc[master]: paging: page all bts when no cell is associated

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 27 07:03:39 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: paging: page all bts when no cell is associated
......................................................................


paging: page all bts when no cell is associated

When the cell identifier list of the BSSMAP paging contains an
"No cell is associated with the transaction." entry then the
paging is dropped and no paging is started at all. This is not
correct. When no cell is associated, the BSS should page the
whole BSS instead.

- Replace respective error case with a paging request to all
  bts.

Change-Id: Id85e3a7540bdc13cd0e780e7870f16c35c6a6a50
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 156ebd3..573625e 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -524,8 +524,8 @@
 
 	switch (cell_ident) {
 	case CELL_IDENT_NO_CELL:
-		LOGP(DMSC, LOGL_NOTICE, "Ignoring no-op paging request for IMSI %s\n", mi_string);
-		return 0; /* nothing to do */
+		page_all_bts(msc, tmsi, mi_string, chan_needed);
+		break;
 
 	case CELL_IDENT_WHOLE_GLOBAL:
 		page_cgi(msc, data, data_length, remain, tmsi, mi_string, chan_needed);

-- 
To view, visit https://gerrit.osmocom.org/6848
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id85e3a7540bdc13cd0e780e7870f16c35c6a6a50
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>


More information about the gerrit-log mailing list