This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: > Ok, agreed. However, for new API functions introduced, like > gsm0808_create_layer3_aoip2 in your patch, I would like to see them > take an aggregate structure as input, rather than an endless list > of function arguments. If we create a new function/symbol, we > don't have to hand mcc/mnc/lac/ci/... as individual arguments > anymore. Does that make sense? Yes ok, makes sense. And btw, how about dropping the _aoip? If it's going to be a general function for AoIP and non-AoIP depending on arg being NULL or not, I guess I'll rather not call it _aoip. Also osmo_cell_global_id is a good pick, I was just reminded of it looking at stsp's cell identifier list patch. We seem to have some separate ecosystems for all of the PLMN/LAC/RAC/CI things :) osmo_cell_global_id and its siblings seem the most sensible ones... -- To view, visit https://gerrit.osmocom.org/6659 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: No