[PATCH] osmo-bsc[master]: bsc_api: drop unknown RR messages.

dexter gerrit-no-reply at lists.osmocom.org
Mon Feb 26 16:56:30 UTC 2018


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6861

to look at the new patch set (#3).

bsc_api: drop unknown RR messages.

Radio Resource (RR) handling is entirely done inside the BSC. However,
the current implementation forwards unknown RR messages to the MSC.
This is not compliant to the specification.

- Remove the forwarding and drop any unknown RR message.

Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
---
M src/libbsc/bsc_api.c
1 file changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/61/6861/3

diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c
index 2dc7b9a..7c9ed6f 100644
--- a/src/libbsc/bsc_api.c
+++ b/src/libbsc/bsc_api.c
@@ -773,14 +773,10 @@
 				api->dtap(conn, link_id, msg);
 			break;
 		default:
-			/* Normally, a MSC should never receive RR
-			 * messages, but we'd rather forward what we
-			 * don't know than drop it... */
+			/* Drop unknown RR message */
 			LOGP(DRR, LOGL_NOTICE,
-			     "BSC: Passing %s 04.08 RR message to MSC\n",
-			     gsm48_rr_msg_name(msg_type));
-			if (api->dtap)
-				api->dtap(conn, link_id, msg);
+			     "%s Dropping %s 04.08 RR message from %s\n",
+			     gsm_lchan_name(conn->lchan), gsm48_rr_msg_name(msg_type));
 		}
 		break;
 	default:

-- 
To view, visit https://gerrit.osmocom.org/6861
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list