osmo-bsc[master]: bsc_api: drop unknown RR messages.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 26 15:49:02 UTC 2018


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/6861/2/src/libbsc/bsc_api.c
File src/libbsc/bsc_api.c:

Line 778: 			     "BSC: Dropping %s 04.08 RR message from %s\n",
sorry, but where do we normally put context information? Always at the beginning of the log message.  I'm surprised this is not known given how much you are looking at log files all the time.

Also, as you're editing anyway; "BSC" is superfluous, as the code always runs only in the BSC , so it might be removed.


-- 
To view, visit https://gerrit.osmocom.org/6861
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list