[PATCH] osmo-mgw[master]: mgcp_client_fsm: Add FSM event names

dexter gerrit-no-reply at lists.osmocom.org
Mon Feb 26 15:12:01 UTC 2018


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6937

to look at the new patch set (#2).

mgcp_client_fsm: Add FSM event names

The FSM lacks a proper definition of the FSM event names. This causes
problems when inspecting the FSM using the VTY.

- Add proper FSM Event names

Change-Id: Ic0990abea2e9fd92546e7b337b5ff3d6f0866321
Related: OS#2924
---
M src/libosmo-mgcp-client/mgcp_client_fsm.c
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/37/6937/2

diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c
index a2565e7..ddbfdd7 100644
--- a/src/libosmo-mgcp-client/mgcp_client_fsm.c
+++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c
@@ -94,6 +94,16 @@
 	EV_DLCX_RESP,
 };
 
+static const struct value_string fsm_mgcp_client_evt_names[] = {
+	OSMO_VALUE_STRING(EV_CRCX),
+	OSMO_VALUE_STRING(EV_CRCX_RESP),
+	OSMO_VALUE_STRING(EV_MDCX),
+	OSMO_VALUE_STRING(EV_MDCX_RESP),
+	OSMO_VALUE_STRING(EV_DLCX),
+	OSMO_VALUE_STRING(EV_DLCX_RESP),
+	{0, NULL}
+};
+
 static struct msgb *make_crcx_msg_bind(struct mgcp_ctx *mgcp_ctx)
 {
 	struct mgcp_msg mgcp_msg;
@@ -533,6 +543,7 @@
 	.num_states = ARRAY_SIZE(fsm_mgcp_client_states),
 	.timer_cb = fsm_timeout_cb,
 	.cleanup = fsm_cleanup_cb,
+	.event_names = fsm_mgcp_client_evt_names,
 };
 
 /*! allocate FSM, and create a new connection on the MGW.

-- 
To view, visit https://gerrit.osmocom.org/6937
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0990abea2e9fd92546e7b337b5ff3d6f0866321
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list