This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgPatch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h File include/osmocom/gsm/gsm0808_utils.h: Line 44: /* Parsed Location Area Code and Cell Identity (CELL_IDENT_LAC_AND_CI) */ > documentation in libraries should generally use Doxygen formatting so it ge OK, I'll update this in the next patch set (which I have not written yet). Line 70: uint8_t id_discr; > this field is neither a union nor is there a comment on how it is used/comp Sorry, I don't understand what you want. Yes, this field is not a union, but I don't see why it should be one. It represents the cell ID discriminator which tells us which member of the union below should be used. If I added a comment documenting the id_discr field, would this address your concern? -- To view, visit https://gerrit.osmocom.org/6509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes