[PATCH] osmo-msc[master]: a_reset: Add FSM event names

dexter gerrit-no-reply at lists.osmocom.org
Mon Feb 26 12:56:42 UTC 2018


Hello Stefan Sperling, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6930

to look at the new patch set (#2).

a_reset: Add FSM event names

The FSM lacks a proper definition of the FSM event names. This causes
problems when inspecting the FSM using the VTY.

- Add proper FSM Event names

Change-Id: I76d7d9e0accffd433a3f3b5e5f8ab17ecd4a348c
Related: OS#2924
---
M src/libcommon-cs/a_reset.c
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/30/6930/2

diff --git a/src/libcommon-cs/a_reset.c b/src/libcommon-cs/a_reset.c
index 25192c3..80e50cf 100644
--- a/src/libcommon-cs/a_reset.c
+++ b/src/libcommon-cs/a_reset.c
@@ -43,6 +43,13 @@
 	EV_N_CONNECT,		/* made a successful connection */
 };
 
+static const struct value_string fsm_event_names[] = {
+	{EV_RESET_ACK, "EV_RESET_ACK"},
+	{EV_N_DISCONNECT, "EV_N_DISCONNECT"},
+	{EV_N_CONNECT, "EV_N_CONNECT"},
+	{0, NULL}
+};
+
 /* Disconnected state */
 static void fsm_disc_cb(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
@@ -111,6 +118,7 @@
 	.num_states = ARRAY_SIZE(fsm_states),
 	.log_subsys = DMSC,
 	.timer_cb = fsm_reset_ack_timeout_cb,
+	.event_names = fsm_event_names,
 };
 
 /* Create and start state machine which handles the reset/reset-ack procedure */

-- 
To view, visit https://gerrit.osmocom.org/6930
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76d7d9e0accffd433a3f3b5e5f8ab17ecd4a348c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>


More information about the gerrit-log mailing list