osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Feb 26 00:27:23 UTC 2018


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/6913/2/src/osmo_ms_driver/simple_loop.py
File src/osmo_ms_driver/simple_loop.py:

Line 41: 
You could add extra checking for the maximum len of 107 chars, in case it is truncated at somedirectory level it will fail to be created. We already experienced this and was an annoying bug. Have a look at bts_osmo.py:44:

        if len(self.pcu_socket_path().encode()) > 107:
            raise log.Error('Path for pcu socket is longer than max allowed len for unix socket path (107):', self.pcu_socket_path())


-- 
To view, visit https://gerrit.osmocom.org/6913
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea06f33870cab9f21e9a1a1feb9758467343dd29
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list