This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh
File contrib/jenkins.sh:
Line 86: if [ -z "${INSIDE_CHROOT}" ]; then
I think this should always be executed, with no condition. Otherwise in the case in which we call us recursively, the workspace won't be cleaned after finishing (since this condition won't be true and exit 0 is called after the recursive call in line 59.
--
To view, visit https://gerrit.osmocom.org/6911
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes