[PATCH] osmo-ttcn3-hacks[master]: bts: Add some more comments for better code grouping

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Feb 25 16:00:51 UTC 2018


Review at  https://gerrit.osmocom.org/6905

bts: Add some more comments for better code grouping

Change-Id: Ibe68067f20d72318716c6a27f02d7bc9b56f1b01
---
M bts/BTS_Tests.ttcn
1 file changed, 28 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/6905/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 7d4469e..ab93c30 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -326,6 +326,10 @@
 	}
 }
 
+/***********************************************************************
+ * Channel Activation / Deactivation
+ ***********************************************************************/
+
 /* Stress test: Do 500 channel activations/deactivations in rapid succession */
 function f_TC_chan_act_stress(charstring id) runs on ConnHdlr {
 	for (var integer i := 0; i < 500; i := i+1) {
@@ -437,6 +441,10 @@
 	}
 }
 
+/***********************************************************************
+ * RACH Handling
+ ***********************************************************************/
+
 function f_TC_chan_req(charstring id) runs on ConnHdlr {
 	f_l1_tune(L1CTL);
 
@@ -452,6 +460,10 @@
 	vc_conn := f_start_handler(refers(f_TC_chan_req), pars);
 	vc_conn.done;
 }
+
+/***********************************************************************
+ * Measurement Processing / Reporting
+ ***********************************************************************/
 
 template LapdmAddressField ts_LapdmAddr(LapdmSapi sapi, boolean c_r) := {
 	spare := '0'B,
@@ -722,6 +734,10 @@
 	vc_conn.done;
 }
 
+/***********************************************************************
+ * Paging
+ ***********************************************************************/
+
 function tmsi_is_dummy(TMSIP_TMSI_V tmsi) return boolean {
 	if (tmsi == 'FFFFFFFF'O) {
 		return true;
@@ -729,7 +745,6 @@
 		return false;
 	}
 }
-
 
 altstep as_l1_count_paging(inout integer num_paging_rcv_msgs, inout integer num_paging_rcv_ids)
 runs on test_CT {
@@ -977,6 +992,10 @@
 }
 
 
+/***********************************************************************
+ * Immediate Assignment / AGCH
+ ***********************************************************************/
+
 testcase TC_imm_ass() runs on test_CT {
 	f_init(testcasename());
 	for (var integer i := 0; i < 1000; i := i+1) {
@@ -996,6 +1015,10 @@
 	/* expect no ERROR REPORT after either of them *
 	/* negative test: ensure ERROR REPORT on unsupported types */
 }
+
+/***********************************************************************
+ * Low-Level Protocol Errors / ERROR REPORT
+ ***********************************************************************/
 
 private function f_exp_err_rep(template RSL_Cause cause) runs on test_CT {
 	timer T := 5.0;
@@ -1046,6 +1069,10 @@
 
 	f_exp_err_rep(RSL_ERR_IE_CONTENT);
 }
+
+/***********************************************************************
+ * IPA CRCX/MDCX/DLCS media stream handling
+ ***********************************************************************/
 
 /* Send IPA DLCX to inactive lchan */
 function f_TC_ipa_dlcx_not_active(charstring id) runs on ConnHdlr {
@@ -1164,7 +1191,6 @@
 * Delete Indication on AGCH overflow
 * SMS Broadcast Req / Cmd / CBCH LOad Ind
 * RF resource ind
-* IPA/speech related commands
 * error handling
 * discriminator error
 ** type error

-- 
To view, visit https://gerrit.osmocom.org/6905
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe68067f20d72318716c6a27f02d7bc9b56f1b01
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>


More information about the gerrit-log mailing list