[MERGED] osmo-ttcn3-hacks[master]: RSL_Types: Remove RT_PT2 from tr_RSL_IPA_CRCX_ACK

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Feb 25 12:31:15 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: RSL_Types: Remove RT_PT2 from tr_RSL_IPA_CRCX_ACK
......................................................................


RSL_Types: Remove RT_PT2 from tr_RSL_IPA_CRCX_ACK

The way how TTCN-3 templates work we cannot use a template parameter
to decide if we want to match only on messages that contain a matching
RTP_PT2, or (alternatively) on any messages whether or not they have
a RTP_PT2 IE at all :(

Change-Id: I7a4f5d7e1d44994316717da5b769e278ea188b12
---
M library/RSL_Types.ttcn
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn
index 79f5920..45d6aec 100644
--- a/library/RSL_Types.ttcn
+++ b/library/RSL_Types.ttcn
@@ -1327,16 +1327,15 @@
 	template RSL_Message tr_RSL_IPA_CRCX_ACK(template RslChannelNr chan_nr,
 						 template uint16_t ipa_conn_id,
 						 template uint32_t local_ip,
-						 template uint16_t local_port,
-						 template uint7_t rtp_pt2) := {
+						 template uint16_t local_port) := {
 		msg_disc := ts_RSL_MsgDisc(RSL_MDISC_IPACCESS, false),
 		msg_type := RSL_MT_IPAC_CRCX_ACK,
 		ies := {
 			tr_RSL_IE(RSL_IE_Body:{chan_nr := chan_nr}),
 			tr_RSL_IE(RSL_IE_Body:{ipa_conn_id := ipa_conn_id}),
 			tr_RSL_IE(RSL_IE_Body:{ipa_local_ip := local_ip}),
-			tr_RSL_IE(RSL_IE_Body:{ipa_local_port := local_port}),
-			tr_RSL_IE(RSL_IE_Body:{ipa_rtp_pt2 := rtp_pt2})
+			tr_RSL_IE(RSL_IE_Body:{ipa_local_port := local_port})
+			/* Optional: RTP Payload Type 2 IE */
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/6891
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a4f5d7e1d44994316717da5b769e278ea188b12
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list