[MERGED] osmo-bts[master]: l1sap: Pass is_sub from L1 primitive into the Uplink Measure...

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 23 19:59:49 UTC 2018

Harald Welte has submitted this change and it was merged.

Change subject: l1sap: Pass is_sub from L1 primitive into the Uplink Measurement

l1sap: Pass is_sub from L1 primitive into the Uplink Measurement

info_meas_ind on the L1SAP always allowed the lower layers to pass
in whether a given measurement is part of the "SUB", or not.

However, the existing l1sap code before this patch simply drops this
information, despite the measurement.c code also having "is_sub" state.

Let's make sure this state is passed from L1SAP into measurement
processing as intended.

Fact is, none of our current lower-layers actually set this is_sub flag
for their primitives passed up in L1SAP, but at least now *if* they
would set that flag, the measurement code would process it as intended.

Related: OS#2978
Change-Id: Ibed2e8d7563b471c6b5dd2214ac4765caf31ed2a
M src/common/l1sap.c
1 file changed, 1 insertion(+), 0 deletions(-)

  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index f6a04ea..3580a73 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -525,6 +525,7 @@
 	ulm.ta_offs_qbits = info_meas_ind->ta_offs_qbits;
 	ulm.ber10k = info_meas_ind->ber10k;
 	ulm.inv_rssi = info_meas_ind->inv_rssi;
+	ulm.is_sub = info_meas_ind->is_sub;
 	/* we assume that symbol period is 1 bit: */
 	set_ms_to_data(lchan, info_meas_ind->ta_offs_qbits / 4, true);

To view, visit https://gerrit.osmocom.org/6854
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibed2e8d7563b471c6b5dd2214ac4765caf31ed2a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder

More information about the gerrit-log mailing list