[PATCH] osmo-bsc[master]: bsc_api: drop unknown RR messages.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Feb 23 17:40:48 UTC 2018


Review at  https://gerrit.osmocom.org/6861

bsc_api: drop unknown RR messages.

Radio Resource (RR) handling is entirely done inside the BSC. However,
the current implementation forwards unknown RR messages to the MSC.
This is not compliant to the specification.

- Remove the forwarding and drop any unknown RR message.

Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
---
M src/libbsc/bsc_api.c
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/61/6861/1

diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c
index 2dc7b9a..1dbda78 100644
--- a/src/libbsc/bsc_api.c
+++ b/src/libbsc/bsc_api.c
@@ -773,14 +773,10 @@
 				api->dtap(conn, link_id, msg);
 			break;
 		default:
-			/* Normally, a MSC should never receive RR
-			 * messages, but we'd rather forward what we
-			 * don't know than drop it... */
+			/* Drop unknown RR message */
 			LOGP(DRR, LOGL_NOTICE,
-			     "BSC: Passing %s 04.08 RR message to MSC\n",
+			     "BSC: Dropping %s 04.08 RR message\n",
 			     gsm48_rr_msg_name(msg_type));
-			if (api->dtap)
-				api->dtap(conn, link_id, msg);
 		}
 		break;
 	default:

-- 
To view, visit https://gerrit.osmocom.org/6861
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list