osmo-trx[master]: osmo-trx: Drop cmd lines and use VTY cfg

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 23 11:47:05 UTC 2018


Patch Set 5:

> We are already breaking backwards compatibility in 6619 anyway
 > since we require the config file to parse  it to init the
 > VTY/logging parts. 

See my related comment on why not initialize the logging also with a translation of the command line argument

 > Furthermore, having both the parameters and the
 > VTY at the same time seems really messy to me.

That's what we had in osmocom projects like openbsc/osmo-nitb for a long time, and continue to have to some
extent.  Lots of things were command-line arguments in the past and have lateer been added to the VTY.

Unless it's a lot of effort to support both ways, I would prefer to have one release that supports both,
but will print related warnings during start-up if the legacy command line arguments are used, and then
remove it in the next release.  This gives people some time.  Also, it would open the possibility to
* start with command line arguments
* do "write file" to generate a config file from those old settings

Also, before we make any related release, we have to make sure all documentation is updated, from wiki to
user manuals, ...

 > It may make sense to make a release before 6618 (depend on
 > libosmocore), and then merge everything at once.

I guess that means reverting the change in master and applying all related patches to branch (via gerrit) first.

-- 
To view, visit https://gerrit.osmocom.org/6651
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
Gerrit-PatchSet: 5
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list