libosmocore[master]: ensure that osmo_fsm vty commands are only installed once

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Feb 23 11:00:42 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6843/1/src/vty/fsm_vty.c
File src/vty/fsm_vty.c:

Line 192: 	if (!osmo_fsm_vty_cmds_installed) {
> what we normally do is 
I doubt we have cases where distinct libraries are installing *the same* vty commands already. Any such case should either have run into assert() and be noticed, or users of such libraries have so far been lucky enough to only ever link to one such library.


-- 
To view, visit https://gerrit.osmocom.org/6843
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10b0b1c1c1bf44c3b8eafc465c1ee06ea2590682
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list