[PATCH] osmocom-bb[master]: host/trxcon/trx_if.c: get rid of useless commands

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 22 15:33:27 UTC 2018


Review at  https://gerrit.osmocom.org/6792

host/trxcon/trx_if.c: get rid of useless commands

The 'SETMAXDLY' command is used on the BTS side to limit maximal
Time of Arrival for access bursts. As we don't receive RACH
bursts on the MS side, the command is useless.

The 'SETRXGAIN' command is used on the BTS side to set initial
receive gain value for TRX. On the MS side it's possible to set
that parameter via command-line options of TRX.

Change-Id: I3e61b4b48193004cdcb241cefabb44c12db93120
---
M src/host/trxcon/trx_if.c
M src/host/trxcon/trx_if.h
2 files changed, 0 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/6792/1

diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index 1f5edb2..c9bf6c8 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -299,16 +299,6 @@
 	return trx_ctrl_cmd(trx, 0, "ADJPOWER", "%d", db);
 }
 
-int trx_if_cmd_setrxgain(struct trx_instance *trx, int db)
-{
-	return trx_ctrl_cmd(trx, 0, "SETRXGAIN", "%d", db);
-}
-
-int trx_if_cmd_setmaxdly(struct trx_instance *trx, int dly)
-{
-	return trx_ctrl_cmd(trx, 0, "SETMAXDLY", "%d", dly);
-}
-
 /*
  * Timeslot Control
  *
diff --git a/src/host/trxcon/trx_if.h b/src/host/trxcon/trx_if.h
index fbfa8b5..02c9ff7 100644
--- a/src/host/trxcon/trx_if.h
+++ b/src/host/trxcon/trx_if.h
@@ -63,9 +63,6 @@
 int trx_if_cmd_setpower(struct trx_instance *trx, int db);
 int trx_if_cmd_adjpower(struct trx_instance *trx, int db);
 
-int trx_if_cmd_setrxgain(struct trx_instance *trx, int db);
-int trx_if_cmd_setmaxdly(struct trx_instance *trx, int dly);
-
 int trx_if_cmd_rxtune(struct trx_instance *trx, uint16_t arfcn);
 int trx_if_cmd_txtune(struct trx_instance *trx, uint16_t arfcn);
 

-- 
To view, visit https://gerrit.osmocom.org/6792
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e61b4b48193004cdcb241cefabb44c12db93120
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list