osmo-bts[master]: RSL: Ensure we don't accept DCHAN messages for CCHAN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 21 19:35:45 UTC 2018


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:

Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
> Why not to use a macros here?
what's wrong with a function? it gets inlined by the compiler anyway...


-- 
To view, visit https://gerrit.osmocom.org/6635
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a78bec63aeb36dd67043d237b27fe880209349
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list