osmo-trx[master]: Logger: Use libosmocore logging system

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Feb 21 19:22:56 UTC 2018


Patch Set 4:

(2 comments)

Re: testing again here:

It still makes sense to check logging here as it uses this Log class on top, which adds locking mechanism.

https://gerrit.osmocom.org/#/c/6620/4/CommonLibs/Makefile.am
File CommonLibs/Makefile.am:

Line 26: AM_CFLAGS = $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS)
> We already have both VTY and CTRL cflags here,
Yes, as we apply them for C files and for CPP files. In this commit I start using libosmocore in cpp files in this directory, that's why it's needed.


https://gerrit.osmocom.org/#/c/6620/4/tests/CommonLibs/Makefile.am
File tests/CommonLibs/Makefile.am:

Line 4: AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS)
> The same question here...
Same answer.


-- 
To view, visit https://gerrit.osmocom.org/6620
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30baac89f53e927f8699d0586b43cccf88ecd493
Gerrit-PatchSet: 4
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list