osmo-trx[master]: Add initial support for logging, vty, ctrl

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Feb 21 18:33:18 UTC 2018


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/6619/4/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:

Line 79: #define DEFAULT_CONFIG_FILE	"/etc/osmocom/osmo-trx.cfg"
I am not sure, is this common for Osmocom projects to
keep the configuration files in '/etc/osmocom/'?

For example, the way of OsmoBTS:

  static const char *config_file = "osmo-bts.cfg";

so, if a configuration file isn't specified by user,
the program will look for "osmo-bts.cfg" in
a current directory.


https://gerrit.osmocom.org/#/c/6619/4/doc/examples/osmo-trx-limesdr.cfg
File doc/examples/osmo-trx-limesdr.cfg:

Line 1: log stderr
This file is definitely unrelated to the change,
and could be a part of another one...


-- 
To view, visit https://gerrit.osmocom.org/6619
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad
Gerrit-PatchSet: 4
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list