[MERGED] osmo-bsc[master]: bssmap_handle_assignm_req(): Don't print log statemens in ma...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 19 12:02:05 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: bssmap_handle_assignm_req(): Don't print log statemens in malloc failure case
......................................................................


bssmap_handle_assignm_req(): Don't print log statemens in malloc failure case

Change-Id: I85528689b5298a13c60ae80fabd8d66459f730a9
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 3e15248..156ebd3 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -889,10 +889,7 @@
 
 reject:
 	resp = gsm0808_create_assignment_failure(cause, NULL);
-	if (!resp) {
-		LOGP(DMSC, LOGL_ERROR, "Channel allocation failure.\n");
-		return -1;
-	}
+	OSMO_ASSERT(resp);
 
 	osmo_bsc_sigtran_send(conn, resp);
 	return -1;

-- 
To view, visit https://gerrit.osmocom.org/6591
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85528689b5298a13c60ae80fabd8d66459f730a9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list