[PATCH] osmo-bsc[master]: bssmap_handle_assignm_req(): Use more conscise error/log mes...

dexter gerrit-no-reply at lists.osmocom.org
Mon Feb 19 10:21:43 UTC 2018


Review at  https://gerrit.osmocom.org/6590

bssmap_handle_assignm_req(): Use more conscise error/log message texts

Change-Id: Iffbdfd7591aaeedf24ff0de5f34093be78e2833a
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/6590/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index c4c2d8a..e029c5f 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -799,13 +799,13 @@
 		rc = gsm0808_dec_aoip_trasp_addr(&rtp_addr, TLVP_VAL(&tp, GSM0808_IE_AOIP_TRASP_ADDR),
 						 TLVP_LEN(&tp, GSM0808_IE_AOIP_TRASP_ADDR));
 		if (rc < 0) {
-			LOGP(DMSC, LOGL_ERROR, "Unable to decode aoip transport address.\n");
+			LOGP(DMSC, LOGL_ERROR, "Unable to decode AoIP transport address.\n");
 			cause = GSM0808_CAUSE_INCORRECT_VALUE;
 			goto reject;
 		}
 		aoip = true;
 	} else {
-		LOGP(DMSC, LOGL_ERROR, "transport address missing. Audio routing will not work.\n");
+		LOGP(DMSC, LOGL_ERROR, "AoIP transport address and CIC missing. Audio will not work.\n");
 		cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING;
 		goto reject;
 	}
@@ -869,7 +869,7 @@
 		conn->user_plane.mgcp_ctx = mgcp_assignm_req(msc->network, msc->network->mgw.client,
 								conn, chan_mode, full_rate);
 		if (!conn->user_plane.mgcp_ctx) {
-			LOGP(DMSC, LOGL_ERROR, "MGCP GW failure, rejecting assignment... (id=%i)\n",
+			LOGP(DMSC, LOGL_ERROR, "MGCP / MGW failure, rejecting assignment... (id=%i)\n",
 				conn->sccp.conn_id);
 			cause = GSM0808_CAUSE_EQUIPMENT_FAILURE;
 			goto reject;

-- 
To view, visit https://gerrit.osmocom.org/6590
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffbdfd7591aaeedf24ff0de5f34093be78e2833a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>


More information about the gerrit-log mailing list