[PATCH] osmo-ttcn3-hacks[master]: L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IME...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 16 17:43:57 UTC 2018


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6535

to look at the new patch set (#3).

L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IMEI_LV

It seems not all encoder paths properly set typeOfIdentity, so
let's make sure we set it correctly.

Change-Id: Ie35dcf7fec901b786eb2127c1a23f5c161c5778c
---
M library/L3_Templates.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/6535/3

diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index db0ea6e..0d1c229 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -66,7 +66,7 @@
 
 /* send template fro Mobile Identity (TMSI) */
 template MobileIdentityTLV ts_MI_TMSI_TLV(OCT4 tmsi) := {
-	elementIdentifier := '0000000'B, /* overwritten */
+	elementIdentifier := '0100011'B,
 	spare1 := '0'B,
 	mobileIdentityLV := ts_MI_TMSI_LV(tmsi)
 }
@@ -120,7 +120,7 @@
 template (value) MobileIdentityLV ts_MI_IMSI_LV(hexstring imsi_digits) := {
 	lengthIndicator := 0, /* overwritten */
 	mobileIdentityV := {
-		typeOfIdentity := '000'B, /* overwritten */
+		typeOfIdentity := '001'B,
 		oddEvenInd_identity := {
 			imsi := f_enc_IMSI_L3(imsi_digits)
 		}
@@ -131,7 +131,7 @@
 template (value) MobileIdentityLV ts_MI_IMEI_LV(hexstring imei_digits) := {
 	lengthIndicator := 0, /* overwritten */
 	mobileIdentityV := {
-		typeOfIdentity := '000'B, /* overwritten */
+		typeOfIdentity := '010'B,
 		oddEvenInd_identity := {
 			imei := f_enc_IMEI_L3(imei_digits)
 		}

-- 
To view, visit https://gerrit.osmocom.org/6535
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie35dcf7fec901b786eb2127c1a23f5c161c5778c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list