[MERGED] osmo-bsc[master]: HO: bsc_handover_start_lchan_change(): set MS to max power o...

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 16 15:37:11 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: HO: bsc_handover_start_lchan_change(): set MS to max power on handover
......................................................................


HO: bsc_handover_start_lchan_change(): set MS to max power on handover

For re-assignment within the same cell, keep the same MS power. But for
handover to another cell, start off with that cell's configured maximum MS
power.

Change-Id: Ia91766d8bb8f543f514726ce9508b7747bb2bcb5
---
M src/libbsc/handover_logic.c
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/handover_logic.c b/src/libbsc/handover_logic.c
index 2b61c93..52e5dd3 100644
--- a/src/libbsc/handover_logic.c
+++ b/src/libbsc/handover_logic.c
@@ -143,7 +143,15 @@
 
 	/* copy some parameters from old lchan */
 	memcpy(&new_lchan->encr, &old_lchan->encr, sizeof(new_lchan->encr));
-	new_lchan->ms_power = old_lchan->ms_power;
+	if (do_assignment) {
+		new_lchan->ms_power = old_lchan->ms_power;
+		new_lchan->rqd_ta = old_lchan->rqd_ta;
+	} else {
+		new_lchan->ms_power =
+			ms_pwr_ctl_lvl(new_bts->band, new_bts->ms_max_power);
+		/* FIXME: do we have a better idea of the timing advance? */
+		//new_lchan->rqd_ta = old_lchan->rqd_ta;
+	}
 	new_lchan->bs_power = old_lchan->bs_power;
 	new_lchan->rsl_cmode = old_lchan->rsl_cmode;
 	new_lchan->tch_mode = old_lchan->tch_mode;
@@ -153,7 +161,6 @@
 	new_lchan->conn = old_lchan->conn;
 	new_lchan->conn->ho_lchan = new_lchan;
 
-	/* FIXME: do we have a better idea of the timing advance? */
 	rc = rsl_chan_activate_lchan(new_lchan,
 				     ho->async ? RSL_ACT_INTER_ASYNC : RSL_ACT_INTER_SYNC,
 				     ho->ho_ref);

-- 
To view, visit https://gerrit.osmocom.org/6466
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia91766d8bb8f543f514726ce9508b7747bb2bcb5
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list