osmo-bsc[master]: vty: 'show bts': print neighbor cells

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 16 08:07:05 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6479/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:

Line 380: 	case NL_MODE_MANUAL_SI5SEP:
I'm not sure if this leads to the correct result.  MANUAL_SI5SEP basically means that the neighbor list for BCCH (SI2) is different from that in SACCH (SI5).  So you would actually have to print both the si_common.neigh_list for SI2 (automatic) *and* the si_common.si5_neigh_list, not just one of them.


-- 
To view, visit https://gerrit.osmocom.org/6479
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dae0e01b81a6f028b39f3edcaf430251ca8fe2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list