osmo-msc[master]: libmsc: bssap: Fix compilation warning

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Feb 15 18:35:52 UTC 2018


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/5424/4/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

Line 313: 	memcpy(msg->l3h, TLVP_VAL(tp, GSM0808_IE_LAYER_3_INFORMATION), msgb_l3len(msg));
> I still don't get why we would want to copy the payload here.  The point of
As the FIXME comment indicates, current code seems a bit hackish, like modifying the tail directly and probably creating a gap between lower layers and l3h.
Now that I think about it, it would even make more sense to use memmove instead?
What do you propose otherwise? just dropping the FIXME comment and leave it as it is now?


-- 
To view, visit https://gerrit.osmocom.org/5424
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list