libosmocore[master]: fsm: allow graceful exit on FSM termination

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 15 12:35:26 UTC 2018


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/6452/2/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

Line 73: 	void (*pre_term)(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause);
we should add new members at the end of the struct.  I think this will make any ABI incompatibility between old-lib/new-app or vice-versa more likely to cause an immediate error (until libversion is bumped)


-- 
To view, visit https://gerrit.osmocom.org/6452
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fdda9fe994753f975a658c0f3fb3615949cc8bb
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list