This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) Sorry, I think it's ugly to have the same code copy+pasted everywhere. Can't we simply do the TLV parsing at a common/shared point and hand the already-parsed tlv_parsed into the indiividual functions? This way there's reduction of code duplication and only one place where we need to check for the tlv parser result. https://gerrit.osmocom.org/#/c/6448/1/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: Line 228: LOGP(DBSSAP, LOGL_ERROR, "Failed parsing TLV -- discarding message!\n"); makes sense to hexdump the message. -- To view, visit https://gerrit.osmocom.org/6448 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aef9a94fa5b2e0b62a9c1744b8e18e5985f788f Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes