This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6423 to look at the new patch set (#2). remove dead code (gsm_parse_reg) Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7 --- M include/osmocom/msc/gsm_data_shared.h M src/libcommon/gsm_data.c 2 files changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/23/6423/2 diff --git a/include/osmocom/msc/gsm_data_shared.h b/include/osmocom/msc/gsm_data_shared.h index af7d89d..32c336b 100644 --- a/include/osmocom/msc/gsm_data_shared.h +++ b/include/osmocom/msc/gsm_data_shared.h @@ -1,7 +1,6 @@ #ifndef _GSM_DATA_SHAREDH #define _GSM_DATA_SHAREDH -#include <regex.h> #include <stdbool.h> #include <stdint.h> @@ -40,11 +39,5 @@ GSM_PAGING_OOM, GSM_PAGING_BUSY, }; - -/* - * help with parsing regexps - */ -int gsm_parse_reg(void *ctx, regex_t *reg, char **str, - int argc, const char **argv) __attribute__ ((warn_unused_result)); #endif diff --git a/src/libcommon/gsm_data.c b/src/libcommon/gsm_data.c index a0ca81a..f7795b2 100644 --- a/src/libcommon/gsm_data.c +++ b/src/libcommon/gsm_data.c @@ -54,31 +54,6 @@ return get_value_string(rrlp_mode_names, mode); } -int gsm_parse_reg(void *ctx, regex_t *reg, char **str, int argc, const char **argv) -{ - int ret; - - ret = 0; - if (*str) { - talloc_free(*str); - *str = NULL; - } - regfree(reg); - - if (argc > 0) { - *str = talloc_strdup(ctx, argv[0]); - ret = regcomp(reg, argv[0], 0); - - /* handle compilation failures */ - if (ret != 0) { - talloc_free(*str); - *str = NULL; - } - } - - return ret; -} - bool classmark_is_r99(struct gsm_classmark *cm) { int rev_lev = 0; -- To view, visit https://gerrit.osmocom.org/6423 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder