This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: MGCP: Response code 250 is *not* an error for DLCX ...................................................................... MGCP: Response code 250 is *not* an error for DLCX Change-Id: I9f64996bfff09561f253115681ed63ee87b90ef3 Closes: OS#2923 --- M src/libmsc/msc_mgcp.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c index 9fee27b..08aa09a 100644 --- a/src/libmsc/msc_mgcp.c +++ b/src/libmsc/msc_mgcp.c @@ -724,7 +724,8 @@ OSMO_ASSERT(mgcp_ctx); - if (r->head.response_code != 200) { + /* DLCX is the only command where 250 is permitted as positive result */ + if (r->head.response_code != 200 && r->head.response_code != 250) { LOGPFSML(mgcp_ctx->fsm, LOGL_ERROR, "DLCX: response yields error: %d %s\n", r->head.response_code, r->head.comment); handle_error(mgcp_ctx, MGCP_ERR_MGW_FAIL); -- To view, visit https://gerrit.osmocom.org/6360 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f64996bfff09561f253115681ed63ee87b90ef3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de>