[MERGED] osmo-trx[master]: UHDDevice: Initialize async_event_thrd in constructor

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 9 15:47:56 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: UHDDevice: Initialize async_event_thrd in constructor
......................................................................


UHDDevice: Initialize async_event_thrd in constructor

Fixes coverity CID 182757.
It's actually a false warning because "async_event_thrd" member is
protected by other member "started", so in practice it's never going to
be used before being initialized in start().

Change-Id: I5d5739bc9d08fe533e4d44c3992005a14e568a4f
---
M Transceiver52M/UHDDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/UHDDevice.cpp b/Transceiver52M/UHDDevice.cpp
index 1687a60..4466da4 100644
--- a/Transceiver52M/UHDDevice.cpp
+++ b/Transceiver52M/UHDDevice.cpp
@@ -369,7 +369,7 @@
 	  rx_gain_min(0.0), rx_gain_max(0.0),
 	  tx_spp(0), rx_spp(0),
 	  started(false), aligned(false), rx_pkt_cnt(0), drop_cnt(0),
-	  prev_ts(0,0), ts_initial(0), ts_offset(0)
+	  prev_ts(0,0), ts_initial(0), ts_offset(0), async_event_thrd(NULL)
 {
 	this->tx_sps = tx_sps;
 	this->rx_sps = rx_sps;

-- 
To view, visit https://gerrit.osmocom.org/6353
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5d5739bc9d08fe533e4d44c3992005a14e568a4f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list