[PATCH] osmo-msc[master]: a_sccp_rx_dt(): Don't print hexdump of message multiple times

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 9 01:21:11 UTC 2018


Review at  https://gerrit.osmocom.org/6332

a_sccp_rx_dt(): Don't print hexdump of message multiple times

We don't need to hexdump it in a_sccp_rx_dt() and then again in
rx_bssmap() or rx_dtap().

Change-Id: I2caa8e0af236983430155f9c808de913377d5780
---
M src/libmsc/a_iface_bssap.c
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/32/6332/1

diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index f91855a..d865ea3 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -698,8 +698,6 @@
 	OSMO_ASSERT(a_conn_info);
 	OSMO_ASSERT(msg);
 
-	LOGP(DMSC, LOGL_DEBUG, "Rx BSC DT: %s\n", msgb_hexdump(msg));
-
 	if (msgb_l2len(msg) < sizeof(struct bssmap_header)) {
 		LOGP(DMSC, LOGL_NOTICE, "The header is too short -- discarding message!\n");
 		msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/6332
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2caa8e0af236983430155f9c808de913377d5780
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>


More information about the gerrit-log mailing list